[asterisk-dev] [Code Review] 2566: autoservice_run ast_frfree missing when already out of mem

wdoekes reviewboard at asterisk.org
Fri Aug 9 10:20:47 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2566/
-----------------------------------------------------------

(Updated Aug. 9, 2013, 3:20 p.m.)


Review request for Asterisk Developers.


Changes
-------

Resolve opticrons suggestion. Thanks for the review :)


Repository: Asterisk


Description
-------

Hi, I'm trying to find the cause of an issue I encountered with a terrible lot of duplicated fax frames.

While browsing the code, I found the following hard to read code. It looks to me like there is a missing ast_frfree() in this off-nominal path when we're out of mem.


Diffs (updated)
-----

  /trunk/main/autoservice.c 396496 

Diff: https://reviewboard.asterisk.org/r/2566/diff/


Testing
-------

None whatsoever.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130809/b0e665b2/attachment.htm>


More information about the asterisk-dev mailing list