[asterisk-dev] [Code Review] 1598: chan_dahdi: create and destroy channels at run-time

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1598/
-----------------------------------------------------------

(Updated Aug. 8, 2013, 7:55 p.m.)


Review request for Asterisk Developers.


Changes
-------

* Fixed previous remarks.
  - pre_destroy_dchan() renamed pri_destroy_span() and also destroys remaining B-channels.
* setup_dahdi_int() will not re-run span/dchan initialization for existing spans (as noted by the existing thread span thread pointer). This e.g. fixed a leak of thread generation.
* No need to run pthread_kill() for our thread, as it does not use pthread_setcancelstate() / pthread_setcanceltype().


Repository: Asterisk


Description
-------

This code adds chan_dahdi the command 'dahdi create channels <range>' (where <range> is a single <n>-<m> or 'all') and updates 'dahdi destroy channel' with a similar 'dahdi destroy channels'.

This change is intended to provide a hook for a script running from udev once a span has been assigned ("registered") / unassigned ("unregistered") for its channels. The udev hook configures the span's channels with dahdi_cfg -S, and can then ask Asterisk to create ethe channels. See the scripts added to DAHDI-tools in 2.7.0.

This means that a separate DAHDI init script (running before the Asterisk one) would no longer be required. There is no longer a need to run a single command after all DAHDI devices are up.

If you use those new DAHDI settings you should set ignore_failed_channels in chan_dahdi.conf to avoid missing a channel failing the startup of chan_dahdi (with potentially other channels already available).


Diffs (updated)
-----

  /trunk/channels/chan_dahdi.c 396321 

Diff: https://reviewboard.asterisk.org/r/1598/diff/


Testing
-------

Works well with analog devices and mostly tested with ISDN devices.


Thanks,

Tzafrir Cohen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130808/0d88474c/attachment.htm>