[asterisk-dev] [Code Review] 2753: testsuite: Improve IAX2 and SIP ACL call tests so that they are more expressive on timeout

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2753/
-----------------------------------------------------------

Review request for Asterisk Developers, kmoore and Matt Jordan.


Bugs: https://issues.asterisk.org/jira/browse/ASTERISK-22212
    https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-22212


Repository: testsuite


Description
-------

These tests now react to failures to reach the next phase during a test before timeout occurs and log information about how the test failed at exit.
In the case of expected failure or success, what events were expected will be indicated along with what events were received. Additionally, details about originate failures will be noted. Basically any known off-nominal conditions present at timeout will be noted in the error logs.

This should help to understand failures if this test stalls in the future.


Diffs
-----

  /asterisk/trunk/tests/channels/SIP/acl_call/run-test 3982 
  /asterisk/trunk/tests/channels/iax2/acl_call/run-test 3982 

Diff: https://reviewboard.asterisk.org/r/2753/diff/


Testing
-------

Changed failure conditions to see what would happen if not enough events were received to evaluate anticipated failure and success phases
Tested with unpatched version of Asterisk (https://reviewboard.asterisk.org/r/2748/) to see what would be indicated for the current round of test failures.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130808/88dd9840/attachment-0001.htm>