[asterisk-dev] [Code Review] 1598: chan_dahdi: create and destroy channels at run-time

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1598/#review9351
-----------------------------------------------------------



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1598/#comment18409>

    Returns RESULT_SUCCESS and RESULT_FAILURE not 0 and -1 respectively.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1598/#comment18408>

    Left over debug message?



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1598/#comment18410>

    Doing this here requires that all B channels are already destroyed.  Is this guaranteed by the DAHDI_EVENT_REMOVED event?  Maybe DAHDI_EVENT_REMOVED should delete the B channels before destroying the D channel?



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1598/#comment18407>

    Use CLI_SUCCESS


- rmudgett


On Aug. 6, 2013, 8:03 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1598/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 8:03 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This code adds chan_dahdi the command 'dahdi create channels <range>' (where <range> is a single <n>-<m> or 'all') and updates 'dahdi destroy channel' with a similar 'dahdi destroy channels'.
> 
> This change is intended to provide a hook for a script running from udev once a span has been assigned ("registered") / unassigned ("unregistered") for its channels. The udev hook configures the span's channels with dahdi_cfg -S, and can then ask Asterisk to create ethe channels. See the scripts added to DAHDI-tools in 2.7.0.
> 
> This means that a separate DAHDI init script (running before the Asterisk one) would no longer be required. There is no longer a need to run a single command after all DAHDI devices are up.
> 
> If you use those new DAHDI settings you should set ignore_failed_channels in chan_dahdi.conf to avoid missing a channel failing the startup of chan_dahdi (with potentially other channels already available).
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 396321 
> 
> Diff: https://reviewboard.asterisk.org/r/1598/diff/
> 
> 
> Testing
> -------
> 
> Works well with analog devices and mostly tested with ISDN devices.
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130807/f2bb14c5/attachment-0001.htm>