[asterisk-dev] [Code Review] 2721: bridge_channels: Add support for the lonely flag

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2721/#review9350
-----------------------------------------------------------



/trunk/include/asterisk/core_unreal.h
<https://reviewboard.asterisk.org/r/2721/#comment18404>

    Period at end of sentence.
    
    Instead, just remove the sentence and require the immovable flag to be passed in for more flexibility.



/trunk/include/asterisk/core_unreal.h
<https://reviewboard.asterisk.org/r/2721/#comment18403>

    Make flags unsigned int.



/trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/2721/#comment18405>

    You have a local variable bridge already.  You don't need to do bridge_channel->bridge when only bridge is necessary.



/trunk/main/core_unreal.c
<https://reviewboard.asterisk.org/r/2721/#comment18402>

    Make the flags unsigned int.



/trunk/main/core_unreal.c
<https://reviewboard.asterisk.org/r/2721/#comment18406>

    This can just be:
    ast_set_flag(&features->feature_flags, AST_BRIDGE_CHANNEL_FLAG_IMMOVABLE | flags)
    
    Actually, I think it would be better to have the immovable flag not unconditionally set and just passed in with the rest of the flags.


- rmudgett


On Aug. 6, 2013, 6:05 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2721/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2013, 6:05 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Matt Jordan, and rmudgett.
> 
> 
> Bugs: ASTERISK-22117
>     https://issues.asterisk.org/jira/browse/ASTERISK-22117
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Channels with the lonely flag are supposed to leave a bridge if all of the channels in that bridge are also lonely at the time of a channel dissolving.
> I also added this flag to ARI play and record on bridge channels.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/bridge.h 396342 
>   /trunk/include/asterisk/core_unreal.h 396342 
>   /trunk/main/bridge_channel.c 396342 
>   /trunk/main/core_unreal.c 396342 
>   /trunk/res/ari/resource_bridges.c 396342 
> 
> Diff: https://reviewboard.asterisk.org/r/2721/diff/
> 
> 
> Testing
> -------
> 
> Tested what happens to channels when a non-lonely channel leaves with and without the presence of non-lonely channels.
> If only lonely channels were left, they hung up. This did produce an ARI playback error since the channel playback was interrupted.
> If non-lonely channels were left, nothing would happen as anticipated.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130807/cf2ac5f4/attachment.htm>