[asterisk-dev] [Code Review] 2566: autoservice_run ast_frfree missing when already out of mem

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2566/
-----------------------------------------------------------

(Updated Aug. 6, 2013, 10:58 a.m.)


Review request for Asterisk Developers.


Changes
-------

Mark says we never get to the mentioned point. Remove the checks.

(I'm reluctant to add extra needless checks in commonly run code. We don't want to slow things down for no reason.)


Repository: Asterisk


Description
-------

Hi, I'm trying to find the cause of an issue I encountered with a terrible lot of duplicated fax frames.

While browsing the code, I found the following hard to read code. It looks to me like there is a missing ast_frfree() in this off-nominal path when we're out of mem.


Diffs (updated)
-----

  /trunk/main/autoservice.c 396318 

Diff: https://reviewboard.asterisk.org/r/2566/diff/


Testing
-------

None whatsoever.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130806/b637a51f/attachment.htm>