[asterisk-dev] [Code Review] 2729: Add outbound registration events to res_pjsip_outbound_registration

[Matt Jordan]

> On Aug. 1, 2013, 3:31 p.m., Joshua Colp wrote:
> > /trunk/res/res_pjsip_outbound_registration.c, lines 113-119
> > <https://reviewboard.asterisk.org/r/2729/diff/1/?file=43440#file43440line113>
> >
> >     A note about how this maps to the above would be useful if someone mucks with it, so they are aware of what they are doing and have a warning.
> 
> Mark Michelson wrote:
>     This can be enforced with the notation of:
>     
>     static const char *sip_outbound_registration_status_str[] = {
>         [SIP_REGISTRATION_UNREGISTERED] = "Unregistered",
>         ...
>     };

Good idea. I'll update it before commit.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2729/#review9284
-----------------------------------------------------------


On Aug. 1, 2013, 1:05 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2729/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While investigating the outbound registration events for chan_sip, I noticed that we weren't raising the events from chan_pjsip's equivalent module, res_pjsip_outbound_registration. Whoops.
> 
> This patch adds the call to raise the event. "username" and "domain" only map so well, so I went with the client_uri/server_uri respectively.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_outbound_registration.c 395907 
> 
> Diff: https://reviewboard.asterisk.org/r/2729/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130805/de9788d3/attachment.htm>