[asterisk-dev] [Code Review] 2739: Test Suite test event for review 2736

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2739/#review9338
-----------------------------------------------------------



/trunk/res/res_pjsip_registrar.c
<https://reviewboard.asterisk.org/r/2739/#comment18389>

    Use ast_strlen_zero:
    
    if (!ast_strlen_zero(aor_name)) {
       ...
    }



/trunk/res/res_pjsip_registrar.c
<https://reviewboard.asterisk.org/r/2739/#comment18390>

    I'm not sure this should be a verbose message. Verbose messages are usually shown to indicate dialplan execution - this message would show up with very little context.
    
    I'd personally make it a debug message.


- Matt Jordan


On Aug. 2, 2013, 10:26 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2739/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2013, 10:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Test Suite test event for review 2736 (https://reviewboard.asterisk.org/r/2736/).
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_pjsip_registrar.c 396156 
> 
> Diff: https://reviewboard.asterisk.org/r/2739/diff/
> 
> 
> Testing
> -------
> 
> Events are received when using '*' in the Contact header to unregister all contacts.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130805/7a3c9318/attachment.htm>