[asterisk-dev] [Code Review] 2722: pjsip tests: Test off-nominal inbound registrations

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2722/#review9336
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On July 31, 2013, 7:12 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2722/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 7:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This includes 3 off-nominal registration tests for pjsip. Each test is performed using IPv4/IPv6 and UDP/TCP. These cover tests 2, 3, and 4 of the off-nominal inbound registrations listed on the test plan page of the wiki.
> 
> * Test no_contact_header - sends a REGISTER to Asterisk which does not contain a Contact header. Ensures that the 200 OK received from Asterisk does not contain a Contact header either.
> 
> * Test max_contacts - sends a REGISTER to Asterisk with two contacts. This ensures that Asterisk responds with a 403 Forbidden since the pjsip configuration option 'max_contacts' is set to 1.
> 
> * Test wrong_password - attempt to register to Asterisk using a password that does not match the pjsip configuration. This ensures that Asterisk rejects the registration attempt with a 401 Unauthorized message.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/sipp/register-wrong-password.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/sipp/register-noauth-no-contact-header.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/sipp/register-too-many-contacts.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/registration/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 3972 
> 
> Diff: https://reviewboard.asterisk.org/r/2722/diff/
> 
> 
> Testing
> -------
> 
> * Ensured the tests fail if:
> - the 200 OK does contain a Contact header
> - a 403 Forbidden is not received
> - a 401 Unauthorized is not received
> * Review logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130805/2c58bf1a/attachment-0001.htm>