[asterisk-dev] [Code Review] 2732: Refactor CEL to avoid using the event system as a distribution mechanism

opticron reviewboard at asterisk.org
Fri Aug 2 08:44:48 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2732/
-----------------------------------------------------------

(Updated Aug. 2, 2013, 8:44 a.m.)


Review request for Asterisk Developers.


Changes
-------

Address Joshua's comments.


Repository: Asterisk


Description
-------

This removes usage of the event system for CEL backend data distribution and strips unused pieces out of the event system.

This build on the work in https://reviewboard.asterisk.org/r/2703/


Diffs (updated)
-----

  team/kmoore/event_system_strip/cel/cel_custom.c 396101 
  team/kmoore/event_system_strip/cel/cel_manager.c 396101 
  team/kmoore/event_system_strip/cel/cel_odbc.c 396101 
  team/kmoore/event_system_strip/cel/cel_pgsql.c 396101 
  team/kmoore/event_system_strip/cel/cel_radius.c 396101 
  team/kmoore/event_system_strip/cel/cel_sqlite3_custom.c 396101 
  team/kmoore/event_system_strip/cel/cel_tds.c 396101 
  team/kmoore/event_system_strip/include/asterisk/_private.h 396101 
  team/kmoore/event_system_strip/include/asterisk/cel.h 396101 
  team/kmoore/event_system_strip/include/asterisk/event.h 396101 
  team/kmoore/event_system_strip/include/asterisk/event_defs.h 396101 
  team/kmoore/event_system_strip/main/asterisk.c 396101 
  team/kmoore/event_system_strip/main/cel.c 396101 
  team/kmoore/event_system_strip/main/event.c 396101 
  team/kmoore/event_system_strip/res/res_pjsip.c 396101 
  team/kmoore/event_system_strip/res/res_pjsip/include/res_pjsip_private.h 396101 
  team/kmoore/event_system_strip/res/res_pjsip/pjsip_options.c 396101 
  team/kmoore/event_system_strip/res/res_pjsip_notify.c 396101 
  team/kmoore/event_system_strip/res/res_pjsip_outbound_registration.c 396101 
  team/kmoore/event_system_strip/tests/test_cel.c 396101 
  team/kmoore/event_system_strip/tests/test_event.c 396101 

Diff: https://reviewboard.asterisk.org/r/2732/diff/


Testing
-------

Unit tests still pass for both CEL and what's left of the event system.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130802/011f1b0f/attachment.htm>


More information about the asterisk-dev mailing list