[asterisk-dev] [Code Review] 2697: ARI: Add recording controls

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2697/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 3:23 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed comment on \param playfile.

Updated for more recent trunk.


Bugs: ASTERISK-22181
    https://issues.asterisk.org/jira/browse/ASTERISK-22181


Repository: Asterisk


Description
-------

This patch implements the controls from ARI recordings. The controls
are:

 * DELETE /recordings/live/{recordingName} - stop recording and
   discard it
 * POST /recordings/live/{recordingName}/stop - stop recording
 * POST /recordings/live/{recordingName}/pause - pause recording
 * POST /recordings/live/{recordingName}/unpause - resume recording
 * POST /recordings/live/{recordingName}/mute - mute recording (record
   silence to the file)
 * POST /recordings/live/{recordingName}/unmute - unmute recording.

Since this underlying functionality did not already exist, is was
added to app.c by a set of control frames, similar to how playback
control works. The pause/mute control frames are toggles, even though
the ARI controls are idempotent, to be consistent with the playback
control frames.


Diffs (updated)
-----

  /trunk/apps/app_minivm.c 395927 
  /trunk/apps/app_voicemail.c 395927 
  /trunk/funcs/func_frame_trace.c 395927 
  /trunk/include/asterisk/app.h 395927 
  /trunk/include/asterisk/frame.h 395927 
  /trunk/include/asterisk/stasis_app_recording.h 395927 
  /trunk/main/app.c 395927 
  /trunk/main/channel.c 395927 
  /trunk/res/ari/resource_recordings.h 395927 
  /trunk/res/ari/resource_recordings.c 395927 
  /trunk/res/res_ari_recordings.c 395927 
  /trunk/res/res_stasis_recording.c 395927 
  /trunk/rest-api/api-docs/recordings.json 395927 

Diff: https://reviewboard.asterisk.org/r/2697/diff/


Testing
-------

Soooo many recordings.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/6c5cb517/attachment.htm>