[asterisk-dev] [Code Review] 2697: ARI: Add recording controls

[David Lee]

> On Aug. 1, 2013, 1:05 p.m., opticron wrote:
> > /trunk/include/asterisk/app.h, line 712
> > <https://reviewboard.asterisk.org/r/2697/diff/2/?file=42966#file42966line712>
> >
> >     Wouldn't this change to the comment mean that playfile is never actually played, only beep?

You're right. I didn't read the comment I had copied on \param been. Will fix.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2697/#review9297
-----------------------------------------------------------


On July 29, 2013, 5:05 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2697/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 5:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22181
>     https://issues.asterisk.org/jira/browse/ASTERISK-22181
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch implements the controls from ARI recordings. The controls
> are:
> 
>  * DELETE /recordings/live/{recordingName} - stop recording and
>    discard it
>  * POST /recordings/live/{recordingName}/stop - stop recording
>  * POST /recordings/live/{recordingName}/pause - pause recording
>  * POST /recordings/live/{recordingName}/unpause - resume recording
>  * POST /recordings/live/{recordingName}/mute - mute recording (record
>    silence to the file)
>  * POST /recordings/live/{recordingName}/unmute - unmute recording.
> 
> Since this underlying functionality did not already exist, is was
> added to app.c by a set of control frames, similar to how playback
> control works. The pause/mute control frames are toggles, even though
> the ARI controls are idempotent, to be consistent with the playback
> control frames.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_minivm.c 395715 
>   /trunk/apps/app_voicemail.c 395715 
>   /trunk/funcs/func_frame_trace.c 395715 
>   /trunk/include/asterisk/app.h 395715 
>   /trunk/include/asterisk/frame.h 395715 
>   /trunk/include/asterisk/stasis_app_recording.h 395715 
>   /trunk/main/app.c 395715 
>   /trunk/main/channel.c 395715 
>   /trunk/res/ari/resource_recordings.h 395715 
>   /trunk/res/ari/resource_recordings.c 395715 
>   /trunk/res/res_ari_recordings.c 395715 
>   /trunk/res/res_stasis_recording.c 395715 
>   /trunk/rest-api/api-docs/recordings.json 395715 
> 
> Diff: https://reviewboard.asterisk.org/r/2697/diff/
> 
> 
> Testing
> -------
> 
> Soooo many recordings.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/b0fa0f57/attachment.htm>