[asterisk-dev] [Code Review] 2730: Install a systemd service unit

[Matt Jordan]

> On Aug. 1, 2013, 7:08 a.m., Tzafrir Cohen wrote:
> > (Not a revieww. Somme extra details that should have gone into the description)
> > 
> > This is aimed at replacing safe_asterisk.
> > 
> > There are various knobs that safe_asterisk touches. I did not set most of them. See the man pages systemd-exec(5) and systemd-service(5)
> > http://www.freedesktop.org/software/systemd/man/systemd.exec.html
> > http://www.freedesktop.org/software/systemd/man/systemd.service.html
> > 
> > Another thing that is not handled here is core files. It could be handled by an ExecStopPost script, however that scriptlet has no information on the exit status of the process. The Fedora Systemd folks have a way more convoluted scheme for handling core files (a daemon listening on a pipe) which required extra setup in the Debian and Fedora system I tested it on.

I'm viewing this one as a "good to get in, but probably needs some more TLC before it becomes a true replacement for safe_asterisk"

The danger of that, of course, is that inevitably bugs get filed, and people have to fix them. :-)

On the other hand, if there's very little risk to having this go into 12, than at least we're trying to keep up with the times, aka, Fedora. (I blame Russell for no good reason)


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2730/#review9269
-----------------------------------------------------------


On Aug. 1, 2013, 1:25 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2730/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 1:25 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21991
>     https://issues.asterisk.org/jira/browse/ASTERISK-21991
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Patch by Tzafrir.
> 
> {quote}
> systemd is a new init system used by various Linux distributions. It aims at providing an environment that is compatible among different distributions, and hence its service configuration files ("units") are eto be provided from Upstream.
> 
> The attached patch includes a simple version of a systemd unit for Asterisk, as well as installing it. It is not enabled, though.
> {quote}
> 
> 
> Diffs
> -----
> 
>   /trunk/Makefile 395920 
>   /trunk/contrib/asterisk.service PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2730/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/401a253e/attachment.htm>