[asterisk-dev] [Code Review] 2694: Clean up queue operations (get rid of BUGBUGs)

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2694/#review9293
-----------------------------------------------------------



/trunk/main/core_local.c
<https://reviewboard.asterisk.org/r/2694/#comment18306>

    Leftover debugging?



/trunk/main/core_local.c
<https://reviewboard.asterisk.org/r/2694/#comment18305>

    Detect allocation failure.



/trunk/main/core_local.c
<https://reviewboard.asterisk.org/r/2694/#comment18303>

    Detect allocation failure.



/trunk/main/core_local.c
<https://reviewboard.asterisk.org/r/2694/#comment18301>

    This needs XML documentation.



/trunk/main/core_local.c
<https://reviewboard.asterisk.org/r/2694/#comment18302>

    Idem.


There are many red blobs throughout the diff.

- opticron


On July 23, 2013, 6:38 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2694/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 6:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21517 and ASTERISK-21943
>     https://issues.asterisk.org/jira/browse/ASTERISK-21517
>     https://issues.asterisk.org/jira/browse/ASTERISK-21943
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Large-scale bridge refactoring left app_queue in a state with lots of commented-out code and many BUGBUG comments.
> 
> This changeset aims to improve app_queue to get back to proper operation. The following changes were made:
> 
> * Reporting of transfers and call completion is done by creating stasis subscriptions and listening for specific events in order to determine when the call is finished (either via a transfer or hangup).
> * Dial end messages have been added where they were previously missing.
> * Queue stats are properly being updated again once calls have finished.
> * AgentComplete stasis messages and AMI events are now occurring again.
> * Mixmonitor starting has been factored into its own function and uses the Mixmonitor API now instead of using ast_pbx_run()
> 
> In addition to the changes in app_queue, there are several supplementary changes as well:
> 
> * Queue logging now differentiates between attended and blind transfers. A note about this is in the CHANGES file.
> * Local channel optimization events now report more information. This includes which of the two local channels involved is the destination of the optimization, the channel that is replacing the destination local channel, and an identifier so that begin and end events can be matched to each other. The end events are now sent whether the optimization was successful or not and includes an indicator of whether the optimization was successful.
> * Changes were made to features and bridging_basic so that additional flags may be set on a bridge. This is necessary because the queue requires that its bridge only allows move-swap local channel optimizations into the bridge.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 395237 
>   /trunk/apps/app_queue.c 395237 
>   /trunk/include/asterisk/app.h 395237 
>   /trunk/include/asterisk/bridging_basic.h 395237 
>   /trunk/include/asterisk/core_unreal.h 395237 
>   /trunk/include/asterisk/features.h 395237 
>   /trunk/main/app.c 395237 
>   /trunk/main/bridging.c 395237 
>   /trunk/main/bridging_basic.c 395237 
>   /trunk/main/core_local.c 395237 
>   /trunk/main/features.c 395237 
> 
> Diff: https://reviewboard.asterisk.org/r/2694/diff/
> 
> 
> Testing
> -------
> 
> Loads.
> 
> The biggest thing that needed to be checked was that hangups and transfers were detected properly. I tested various local channel optimization scenarios to ensure that they worked as expected. I also ensured that the mixmonitor changes worked as expected.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/1db7ae68/attachment-0001.htm>