[asterisk-dev] [Code Review] 2704: Expose res_sip threadpool options

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2704/#review9271
-----------------------------------------------------------

Ship it!


Just remember - res_sip is now res_pjsip. ;)


trunk/res/res_sip.c
<https://reviewboard.asterisk.org/r/2704/#comment18270>

    I'm not a huge fan of "tp" since it requires thought to remember tp = thread pool. I'd s/tp/threadpool/ it myself.


- Joshua Colp


On July 26, 2013, 5:36 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2704/
> -----------------------------------------------------------
> 
> (Updated July 26, 2013, 5:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22143
>     https://issues.asterisk.org/jira/browse/ASTERISK-22143
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Expose initial size, maximum size, and idle timeout as configurable parameters for the res_sip thread pool.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_sip.c 395524 
>   trunk/res/res_sip/config_system.c 395524 
>   trunk/res/res_sip/include/res_sip_private.h 395524 
> 
> Diff: https://reviewboard.asterisk.org/r/2704/diff/
> 
> 
> Testing
> -------
> 
> Made sure that Asterisk came up and calls still worked.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130801/e02c6049/attachment.htm>