[asterisk-dev] [Code Review] 2478: Support multiple Require: and Supported: headers in the same request

[Olle E Johansson]

> On April 29, 2013, 10:14 p.m., Alec Davis wrote:
> > branches/1.8/channels/sip/reqresp_parser.c, lines 1595-1598
> > <https://reviewboard.asterisk.org/r/2478/diff/2/?file=36551#file36551line1595>
> >
> >     Is this deletion related?

Yes, since we call the function once per header line, we can't zero out the "unsupported" string every time. Thanks for all the feedback, will try to work through it and commit soon.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2478/#review8396
-----------------------------------------------------------


On April 29, 2013, 2:38 p.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2478/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 2:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21721
>     https://issues.asterisk.org/jira/browse/ASTERISK-21721
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> We have servers sending multiple Supported: and Require: options in separate headers in the same message. This patch fixes that support so that we parse more than the first header found.
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 386791 
>   branches/1.8/channels/sip/reqresp_parser.c 386791 
> 
> Diff: https://reviewboard.asterisk.org/r/2478/diff/
> 
> 
> Testing
> -------
> 
> Tested with the server that caused the issue. Problem solved and we did reach interoperability!
> 
> 
> Thanks,
> 
> Olle E Johansson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130430/82b98828/attachment.htm>