[asterisk-dev] [Code Review] 2447: res_parking: Rebuilding parking from the ground up to work with the new bridging model

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2447/
-----------------------------------------------------------

(Updated April 26, 2013, 10:45 p.m.)


Review request for Asterisk Developers, David Lee, kmoore, Matt Jordan, Mark Michelson, and rmudgett.


Changes
-------

Describing everything this update handles would be tough, so here are a few major points...

parking_lot_state is now just named parking_lot and the configuration is now referenced by the parking_lot. Reloading and some other stuff had to be changed a bit to handle this.
parked users are now generated as part of the push function. The push function is now capable of failing. A lot of stuff has to be told what to do asynchronously now, so stasis is used to do things like inform a parking channel when they failed to park someone or where they were parked to. Information about parked/parking channels and options related to that is now in datastores so that it can be used by the push function as well.
Multiparty bridges may now be parked. It's pretty insane and awesome.
Some support for the BLINDTRANSFER variable is implemented now.

There are a lot of other smaller details changed.


Bugs: ASTERISK-21059, ASTERISK-21272 and ASTERISK-21353
    https://issues.asterisk.org/jira/browse/ASTERISK-21059
    https://issues.asterisk.org/jira/browse/ASTERISK-21272
    https://issues.asterisk.org/jira/browse/ASTERISK-21353


Repository: Asterisk


Description
-------

As a result of all the new bridging changes, certain applications such as parking, queues, confbridge, and a few others require significant reworking within Asterisk to make usable.
Parking was less than salvagable, so I've rebuilt it from the ground up to use a lot of new stuff including config hooks, the new bridging architecture, stasis, and just generally to
be an independent module with its own scope that doesn't get tangled into a giant morass within features.c

Parking configuration works somewhat differently now and extensions aren't necessarily automatically generated (it's optional and hasn't been implemented), but the intention with the final result is that if you were using parking before without too much additional dialplan manipulation, that should all just work once your parking lots are migrated to the new configuration file.

Currently supported:
parking from the PBX with the Park application (all arguments are supported)
parking within a call using the one touch parking feature
parking within a call using DTMF blind transfers (attended transfers work, but it's basically just like they called the application itself).
Picking up parked calls using the PBX
Multiple parking lots
All options available to parking lots are currently configurable. Some aren't currently doing anything, namely parkext and hints.

To do list:
* Dialplan generation for parking lots with parkext (included 'Park' and 'ParkedCall' applications)
* Dialplan generation for comebacktoorigin (park-dial extensions)
* Hints
* Implement 'Park' manager action
* Dynamic parking lots and the default parking lot
* Scraping the greasy remnants of parking out of features.c
* CEL events
* Unit tests and testsuite tests


Diffs (updated)
-----

  /team/group/bridge_construction/CHANGES 386687 
  /team/group/bridge_construction/bridges/bridge_builtin_features.c 386687 
  /team/group/bridge_construction/configs/res_parking.conf.sample PRE-CREATION 
  /team/group/bridge_construction/include/asterisk/bridging.h 386687 
  /team/group/bridge_construction/include/asterisk/config_options.h 386687 
  /team/group/bridge_construction/include/asterisk/features.h 386687 
  /team/group/bridge_construction/include/asterisk/parking.h PRE-CREATION 
  /team/group/bridge_construction/main/bridging.c 386687 
  /team/group/bridge_construction/main/bridging_roles.c 386687 
  /team/group/bridge_construction/main/config_options.c 386687 
  /team/group/bridge_construction/main/features.c 386687 
  /team/group/bridge_construction/main/parking.c PRE-CREATION 
  /team/group/bridge_construction/res/Makefile 386687 
  /team/group/bridge_construction/res/parking/parking_applications.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/parking_bridge.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/parking_bridge_features.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/parking_controller.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/parking_manager.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/parking_ui.c PRE-CREATION 
  /team/group/bridge_construction/res/parking/res_parking.h PRE-CREATION 
  /team/group/bridge_construction/res/res_parking.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2447/diff/


Testing
-------

This is currently being tested as it's developed and breaks in minor ways frequently. Unit tests and testsuite tests are on the to do list.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130426/e1ff0ea4/attachment-0001.htm>