[asterisk-dev] [Code Review] 2468: Pimp My SIP: SDES SRTP Support

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2468/
-----------------------------------------------------------

(Updated April 25, 2013, 2:36 p.m.)


Review request for Asterisk Developers.


Changes
-------

Remove duplicated content in new files.


Bugs: ASTERISK-21416
    https://issues.asterisk.org/jira/browse/ASTERISK-21416


Repository: Asterisk


Description
-------

Add support for SDES SRTP in chan_gulp/res_sip.  Available options for media encryption for a given endpoint are deny (no encryption allowed), no (none offered by default, but silent upgrade to SDES allowed), and sdes.  This also supports mid-call rekeying as far as I could test it.  Much of the code necessary for this functionality was factored out of chan_sip or pulled from channels/sip/.


Diffs (updated)
-----

  team/group/pimp_my_sip/channels/chan_sip.c 386429 
  team/group/pimp_my_sip/channels/sip/include/sdp_crypto.h 386429 
  team/group/pimp_my_sip/channels/sip/include/sip.h 386429 
  team/group/pimp_my_sip/channels/sip/include/srtp.h 386429 
  team/group/pimp_my_sip/channels/sip/sdp_crypto.c 386429 
  team/group/pimp_my_sip/channels/sip/srtp.c 386429 
  team/group/pimp_my_sip/configs/res_sip.conf.sample 386430 
  team/group/pimp_my_sip/include/asterisk/res_sip.h 386429 
  team/group/pimp_my_sip/include/asterisk/res_sip_session.h 386429 
  team/group/pimp_my_sip/include/asterisk/sdp_srtp.h PRE-CREATION 
  team/group/pimp_my_sip/main/sdp_srtp.c PRE-CREATION 
  team/group/pimp_my_sip/res/res_sip/sip_configuration.c 386429 
  team/group/pimp_my_sip/res/res_sip_sdp_rtp.c 386429 
  team/group/pimp_my_sip/res/res_sip_session.c 386429 

Diff: https://reviewboard.asterisk.org/r/2468/diff/


Testing
-------

Hand testing with several SRTP-capable endpoints and mid-call rekeying tested with minor tweaks to an otherwise unmodified chan_sip.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130425/df7bb267/attachment.htm>