[asterisk-dev] [Code Review] 2456: Pimp My SIP: Add SUBSCRIBE/NOTIFY support and MWI support

[rmudgett]

> On April 22, 2013, 5:05 p.m., Joshua Colp wrote:
> > /team/group/pimp_my_sip/res/res_sip_pubsub.c, lines 272-279
> > <https://reviewboard.asterisk.org/r/2456/diff/2/?file=36297#file36297line272>
> >
> >     Richard added a function which does this essentially, and just fills in a buffer for you. You can use it instead.

The function is ast_uuid_generate_str().  As a bonus it will not fail.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2456/#review8341
-----------------------------------------------------------


On April 19, 2013, 10:10 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2456/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 10:10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21259 and ASTERISK-21260
>     https://issues.asterisk.org/jira/browse/ASTERISK-21259
>     https://issues.asterisk.org/jira/browse/ASTERISK-21260
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds an API for SUBSCRIBE/NOTIFY support within chan_sip and provides an MWI module as the first user of the API.
> 
> The API allows for subscription handlers to register themselves as being able to handle specific event types and what sort of body types they accept. The API allows for subscription handlers to function either as subscribers or notifiers.
> 
> Subscription handlers are called into during certain milestones of a subscription. It is all documented in res_sip_pubsub.h
> 
> I added MWI support as a way of proving the concept of the API. MWI was both a good and a bad choice for this. MWI can be either solicited or unsolicited. Unsolicited MWI does not make use of the new API at all, but solicited MWI does. The solicited MWI is relatively straightforward as compared to unsolicited.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 386158 
>   /team/group/pimp_my_sip/include/asterisk/res_sip_pubsub.h PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip/location.c 386158 
>   /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 386158 
>   /team/group/pimp_my_sip/res/res_sip/sip_distributor.c 386158 
>   /team/group/pimp_my_sip/res/res_sip_mwi.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_pubsub.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_pubsub.exports.in PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2456/diff/
> 
> 
> Testing
> -------
> 
> I tested both solicited and unsolicited MWI.
> 
> I tested unsolicited MWI using a Polycom phone. I ensured that as voicemail state changed, the phone was updated with NOTIFYs that contained the proper message count.
> 
> I tested solicited MWI using both Jitsi and SIPp. I used Jitsi in order to ensure that the subscription was handled correctly and that MWI NOTIFYs were sent when the voicemail state changed. I used SIPp to test that unsubscribing from MWI notifications worked properly.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130422/827d0c3f/attachment-0001.htm>