[asterisk-dev] [Code Review] 2446: Create basic bridge subclass of struct ast_bridge.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2446/#review8318
-----------------------------------------------------------

Ship it!


I've looked through this on a couple of occasions now and I think it's good to go.

- jrose


On April 12, 2013, 6:10 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2446/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 6:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21332
>     https://issues.asterisk.org/jira/browse/ASTERISK-21332
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Create the basic bridge subclass of struct ast_bridge.  This bridge class is the normal bridge for most calls.  It adds management of the DTMF feature hooks for each channel while they are in this bridge.  When the basic two party bridge expands into a multi-party bridge, the various parties can drop out of the bridge without destroying it.
> 
> The new bridging API does not allow casual knowledge of what channels are bridged with a particular channel because there can be more than one.  With this restriction, the support of the [applicationmap] ActivatedBy feature option no longer makes sense and cannot be supported.  The ActivatedBy option is now just ignored.  The feature can only be activated by the channel it is attached to and not by its peer.
> 
> 
> Diffs
> -----
> 
>   team/group/bridge_construction/funcs/func_channel.c 385512 
>   team/group/bridge_construction/include/asterisk/bridging_basic.h PRE-CREATION 
>   team/group/bridge_construction/include/asterisk/bridging_features.h 385512 
>   team/group/bridge_construction/main/bridging.c 385512 
>   team/group/bridge_construction/main/bridging_basic.c PRE-CREATION 
>   team/group/bridge_construction/main/features.c 385512 
>   team/group/bridge_construction/configs/features.conf.sample 385512 
> 
> Diff: https://reviewboard.asterisk.org/r/2446/diff/
> 
> 
> Testing
> -------
> 
> Normal calls are able to do DTMF blind and attended transfers.  The features.conf [featuremap], [applicationmap], and feature-group sections work as expected.  The DYNAMIC_FEATURES channel variable is parsed just like before with the exception of the ActivatedBy option.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130418/a887d5c2/attachment-0001.htm>