[asterisk-dev] [Code Review] 2442: Add nominal bridging tests for blind, attended, and blonde transfers

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2442/#review8314
-----------------------------------------------------------

Ship it!


These tests function correctly and cover everything they intend to.

The singleton pattern used seems to be unnecessary given that Charlie could hang up after sending the Userevent and the connected line information could be gleaned from existing AMI events from the UUT.

- opticron


On April 15, 2013, 2:30 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2442/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20054
>     https://issues.asterisk.org/jira/browse/ASTERISK-20054
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds tests to the Asterisk Test Suite for DTMF tranfers. These tests cover when the transfer operations actually work, and cover blind, attended, and blonde transfers. The transfer target is Charlie; the tests always check that both Alice and Bob can perform the transfer operation. Connected line on the transfer target is verified during the test.
> 
> Note that these tests do not include CDRs or CEL checking yet.
> 1) CDR checking doesn't make much sense until the CDR work is farther along and includes bridging work, as (a) CDRs are currently not defined in transfer scenarios and (b) it's all going to change anyway
> 2) CEL checking, as it is done currently, can't handle unordered CEL events (and things don't always have a deterministic ordering when a transfer happens). We'll need to circle back and re-working our test infrastructure for that support. Also, this is going to change a lot again.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 3703 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/configs/ast1/sip-alice.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/configs/ast4/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/configs/ast4/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_nominal/transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/atxfer_setup/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/automixmon/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/automon/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/configs/ast1/sip-alice.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/configs/ast4/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/configs/ast4/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_nominal/transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blindxfer_setup/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/blonde_nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blonde_nominal/configs/ast1/sip-alice.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blonde_nominal/configs/ast4/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blonde_nominal/configs/ast4/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blonde_nominal/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/blonde_nominal/transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/connected_line_update/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/dial_LS_options/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/disconnect/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/parkcall/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/simple_bridge/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/tests.yaml 3703 
>   /asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml 3703 
>   /asterisk/trunk/tests/bridge/transfer_failure/test-config.yaml 3703 
> 
> Diff: https://reviewboard.asterisk.org/r/2442/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130418/ef168f09/attachment.htm>