[asterisk-dev] [Code Review] 2455: Add support for DTMF via SIP INFO

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2455/#review8286
-----------------------------------------------------------


I'm not sure if the goal here is having basic INFO DTMF support or if your goal is parity with chan_sip's support for INFO DTMF. If you're going for feature parity, then you're missing support for the "short" INFO DTMF (application/dtmf). This is a version that simply puts the DTMF digit in the body and nothing else.

Also, chan_sip understands "application/vnd.nortelnetworks.digits" as being the same thing as "application/dtmf-relay"


/team/group/pimp_my_sip/channels/chan_gulp.c
<https://reviewboard.asterisk.org/r/2455/#comment15949>

    I can't think of a good reason for this to be a synchronous task. There's no need to hold up the channel thread while creating and sending the INFO request.



/team/group/pimp_my_sip/res/res_sip_dtmf_info.c
<https://reviewboard.asterisk.org/r/2455/#comment15947>

    The indentation of this function becomes a bit much at points. One way to alleviate that would be to reverse this if statement and return early.



/team/group/pimp_my_sip/res/res_sip_dtmf_info.c
<https://reviewboard.asterisk.org/r/2455/#comment15948>

    This is another case where the if test can be reversed to reduce indentation.



/team/group/pimp_my_sip/res/res_sip_dtmf_info.c
<https://reviewboard.asterisk.org/r/2455/#comment15946>

    It appears that if a DTMF INFO were received that had no duration, then the if here would be testing an uninitialized variable.


- Mark Michelson


On April 16, 2013, 6:24 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2455/
> -----------------------------------------------------------
> 
> (Updated April 16, 2013, 6:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21261
>     https://issues.asterisk.org/jira/browse/ASTERISK-21261
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Sending is done inside of chan_gulp, if the dtmf= setting in res_sip.conf is set to info.  Receiving is done as a separate module, since that made the most sense, to me.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 385887 
>   /team/group/pimp_my_sip/res/res_sip_dtmf_info.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2455/diff/
> 
> 
> Testing
> -------
> 
> DTMF gets parsed properly.  Outgoing packet looks okay.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130416/1f386ca2/attachment.htm>