[asterisk-dev] [Code Review] 2410: Transition Presence State usage to Stasis

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2410/#review8282
-----------------------------------------------------------

Ship it!



trunk/include/asterisk/presencestate.h
<https://reviewboard.asterisk.org/r/2410/#comment15943>

    Give this struct a doxygen comment all its own.



trunk/main/pbx.c
<https://reviewboard.asterisk.org/r/2410/#comment15944>

    This isn't strictly necessary, but if you feel like it, you could be clever here with a scoped AO2 lock. Then you wouldn't have to ao2_unlock on each continue.


- Matt Jordan


On April 1, 2013, 5:10 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2410/
> -----------------------------------------------------------
> 
> (Updated April 1, 2013, 5:10 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-21102
>     https://issues.asterisk.org/jira/browse/ASTERISK-21102
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Convert presence state events to Stasis messages and remove now-redundant serializers.
> 
> 
> Diffs
> -----
> 
>   trunk/funcs/func_presencestate.c 384324 
>   trunk/include/asterisk/presencestate.h 384324 
>   trunk/main/pbx.c 384324 
>   trunk/main/presencestate.c 384324 
> 
> Diff: https://reviewboard.asterisk.org/r/2410/diff/
> 
> 
> Testing
> -------
> 
> Passes func_presencestate unit test which was also converted to use Stasis.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130415/0c8b0aa5/attachment.htm>