[asterisk-dev] [Code Review] 2439: Refactor AMI DTMF event generation; add DTMF events to stasis-http websocket

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2439/
-----------------------------------------------------------

(Updated April 12, 2013, 4:44 p.m.)


Review request for Asterisk Developers.


Changes
-------

Brought in line with AMI 1.4 spec.


Bugs: ASTERISK-21282 and ASTERISK-21359
    https://issues.asterisk.org/jira/browse/ASTERISK-21282
    https://issues.asterisk.org/jira/browse/ASTERISK-21359


Repository: Asterisk


Description
-------

DTMF events are now published on a channel's stasis_topic. AMI was
refactored to use these events rather than producing the events directly
in channel.c. Finally, the code was added to app_stasis to produce
DTMF events on the WebSocket.

The AMI events are completely backward compatible, including sending
events on transmitted DTMF, and sending DTMF start events.

The Stasis-HTTP events are somewhat simplified. Since DTMF start and
DTMF send events are generally less useful, Stasis-HTTP will only send
events on received DTMF end.

(closes issue ASTERISK-21282)
(closes issue ASTERISK-21359)
Review: https://reviewboard.asterisk.org/r/2439


Diffs (updated)
-----

  /trunk/apps/app_stasis.c 385170 
  /trunk/include/asterisk/cli.h 385170 
  /trunk/include/asterisk/strings.h 385170 
  /trunk/main/channel.c 385170 
  /trunk/main/manager_channels.c 385170 

Diff: https://reviewboard.asterisk.org/r/2439/diff/


Testing
-------

Both AMI and Stasis DTMF events were generated for a few channels.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130412/bbb8fb2d/attachment-0001.htm>