[asterisk-dev] [Code Review] 2449: Don't rebuild things (e.g. XML docs), unnecessarily

David Lee reviewboard at asterisk.org
Fri Apr 12 16:00:20 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2449/#review8263
-----------------------------------------------------------

Ship it!


Simple, and it works. Ship it!

- David Lee


On April 12, 2013, 3:48 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2449/
> -----------------------------------------------------------
> 
> (Updated April 12, 2013, 3:48 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Things are getting rebuilt unnecessarily.  An example is XML docs getting build first on 'make', and then again on 'make install', despite nothing having changed.
> 
> This just removes the cleantest target, and just checks for .lastclean directly.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/Makefile 385521 
> 
> Diff: https://reviewboard.asterisk.org/r/2449/diff/
> 
> 
> Testing
> -------
> 
> Changes to .cleancount correctly cause a make clean to occur.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130412/53a242c2/attachment.htm>


More information about the asterisk-dev mailing list