[asterisk-dev] [Code Review] 2425: Add bridge CLI commands.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2425/#review8232
-----------------------------------------------------------



/team/group/bridge_construction/include/asterisk/bridging.h
<https://reviewboard.asterisk.org/r/2425/#comment15894>

    Tollerates -> Tolerates



/team/group/bridge_construction/main/bridging.c
<https://reviewboard.asterisk.org/r/2425/#comment15898>

    This code can be pulled below the switch by putting a return in the default case to reduce indentation.  Other things can be done to reduce the indentation here as well.



/team/group/bridge_construction/main/bridging.c
<https://reviewboard.asterisk.org/r/2425/#comment15899>

    Change this to "Show information about a bridge" or something similar.



/team/group/bridge_construction/main/bridging.c
<https://reviewboard.asterisk.org/r/2425/#comment15901>

    Usage text terminology should be consistent.  I see "a specific", "the specified", and a lack of any form of "specify" when querying or acting on items by their identifiers.


- opticron


On April 8, 2013, 4:45 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2425/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 4:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21331
>     https://issues.asterisk.org/jira/browse/ASTERISK-21331
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> * Added bridge CLI commands:
> bridge destroy <bridge-id>
> bridge kick <bridge-id> <channel>
> bridge show all
> bridge show <bridge-id>
> bridge technology show
> bridge technology {suspend|unsuspend} <technology>
> 
> * Created global bridges container for manipulation by bridge CLI commands.
> 
> * Add ast_bridge_register() for ast_bridge_xxx_new() calls to register the bridge for access by the CLI commands.
> 
> 
> Diffs
> -----
> 
>   /team/group/bridge_construction/main/bridging.c 385038 
>   /team/group/bridge_construction/include/asterisk/bridging.h 385038 
>   /team/group/bridge_construction/main/features.c 385038 
> 
> Diff: https://reviewboard.asterisk.org/r/2425/diff/
> 
> 
> Testing
> -------
> 
> The new CLI commands work as expected.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130411/ca271d5c/attachment-0001.htm>