[asterisk-dev] [Code Review] 2430: Moved core logic from app_stasis to res_stasis

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2430/
-----------------------------------------------------------

(Updated April 9, 2013, 2:47 p.m.)


Review request for Asterisk Developers, Matt Jordan and opticron.


Changes
-------

Addressed Paul's feedback. The ast_channel_snapshot_to_json is now much cleaner, and has a unit test to ensure I didn't break anything.


Repository: Asterisk


Description
-------

After some discussion on asterisk-dev, it was decided that the bulk of
the logic in app_stasis actually belongs in a resource module instead
of the application module.

This patch does that, leaves the app specific stuff in app_stasis, and
fixes up everything else to be consistent with that change.

 * Renamed test_app_stasis to test_res_stasis
 * Renamed app_stasis.h to stasis_app.h
   * This is still stasis application support, even though it's no
     longer in an app_ module. The name should never have been tied to
     the type of module, anyways.
 * Now that json isn't a resource module anymore, moved the
   ast_channel_snapshot_to_json function to main/stasis_channels.c,
   where it makes more sense.


Diffs (updated)
-----

  /trunk/apps/Makefile 385141 
  /trunk/apps/app_stasis.c 385141 
  /trunk/apps/app_stasis.exports.in 385141 
  /trunk/apps/stasis_json.c 385141 
  /trunk/include/asterisk/app_stasis.h 385141 
  /trunk/include/asterisk/json.h 385141 
  /trunk/include/asterisk/stasis_app.h PRE-CREATION 
  /trunk/include/asterisk/stasis_channels.h 385141 
  /trunk/main/json.c 385141 
  /trunk/main/stasis_channels.c 385141 
  /trunk/res/res_stasis.c PRE-CREATION 
  /trunk/res/res_stasis.exports.in PRE-CREATION 
  /trunk/res/res_stasis_websocket.c 385141 
  /trunk/tests/test_app_stasis.c 385141 
  /trunk/tests/test_json.c 385141 
  /trunk/tests/test_res_stasis.c PRE-CREATION 
  /trunk/tests/test_stasis_channels.c 385141 

Diff: https://reviewboard.asterisk.org/r/2430/diff/


Testing
-------

Unit tests still pass.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130409/7ffc334d/attachment.htm>