[asterisk-dev] [Code Review] 2386: Default Global Settings Not Being Overridden - Asterisk 1.8

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2386/#review8201
-----------------------------------------------------------

Ship it!


Ship It!

- wdoekes


On April 5, 2013, 8:53 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2386/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 8:53 p.m.)
> 
> 
> Review request for Asterisk Developers and wdoekes.
> 
> 
> Bugs: ASTERISK-21225
>     https://issues.asterisk.org/jira/browse/ASTERISK-21225
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Same as https://reviewboard.asterisk.org/r/2385/ but for Asterisk 1.8 since the two have some differences.
> 
> The initial report was that the "nat" setting in the [general] section was not having any effect in overriding the default setting.  Upon confirming this and checking into what was happening, it looks like other default settings would not be overridden as well.
> 
> This patch works similar to what occurs in build_peer().  We create a temporary ast_flags structure and using the mask, we override the default global options with whatever is set in the [general] section.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/UPGRADE.txt 384778 
>   /branches/1.8/channels/chan_sip.c 384779 
> 
> Diff: https://reviewboard.asterisk.org/r/2386/diff/
> 
> 
> Testing
> -------
> 
> Reporter tested this patch on his 1.8 machine and confirmed that everything is working properly.  He also noted that the "directmedia" settings are now being set properly as a result of this patch.
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130408/8f399b99/attachment.htm>