[asterisk-dev] [Code Review] 2422: Backport Appropiate NAT Setting Cleanups To 1.8

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2422/#review8180
-----------------------------------------------------------

Ship it!


The actual code itself looks fine by me.

As far as Walter's suggestion goes, I can go either way on it. I don't think changing to use a varchar is overly invasive mid-release for a script in the contrib directory, so if you want to make his suggested change, I say go for it.

- Mark Michelson


On April 2, 2013, 8:14 p.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2422/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 8:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21243
>     https://issues.asterisk.org/jira/browse/ASTERISK-21243
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> ASTERISK-20904 was centered around the changes that took place in Asterisk 11 in regards to the auto_* NAT settings.  Since the report stated that 1.8 was fine but that 11 had an issue, the focus was on Asterisk 11.
> 
> While working on ASTERISK-21225, I saw that 1.8 would benefit from some of those changes but requires a different patch.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 382826 
>   /branches/1.8/contrib/realtime/mysql/sippeers.sql 382826 
>   /branches/1.8/contrib/realtime/postgresql/realtime.sql 382826 
> 
> Diff: https://reviewboard.asterisk.org/r/2422/diff/
> 
> 
> Testing
> -------
> 
> compile test
> Same changes as ASTERISK-20904 but for 1.8 - so, we can kind of say it has been tested :)
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130404/ae77a7c2/attachment.htm>