[asterisk-dev] [Code Review] 2383: Refactor Dialing to publish Stasis-Core messages

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2383/
-----------------------------------------------------------

(Updated April 2, 2013, 3:34 a.m.)


Review request for Asterisk Developers and David Lee.


Changes
-------

Addressed David's findings.


Bugs: ASTERISK-21196
    https://issues.asterisk.org/jira/browse/ASTERISK-21196


Repository: Asterisk


Description
-------

As part of the CDR work for Asterisk 12 (see https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CDR+Specification), we need Dial information published over Stasis-Core. This patch refactors app_dial to publish the necessary events.

The Dial based events are slightly different in Asterisk 12 than in other previous versions:
 * Dial is now two events, DialBegin and DialEnd. This matches the nomenclature of other AMI events. See https://wiki.asterisk.org/wiki/display/AST/AMI+1.4+Specification for more information.
 * Dial events now occur at the beginning of a dial operation and when the status of the dial operation is known. Previously, it occurred on application exit, which occurred after bridging.

Note that other applications will need refactoring as well (such as the Dial Framework, Queue, FollowMe, etc.) - however, in order to limit the scope of the work, I've kept it only to app_dial at this point.


Diffs (updated)
-----

  /trunk/tests/test_stasis_channels.c PRE-CREATION 
  /trunk/pbx/pbx_realtime.c 384513 
  /trunk/main/stasis_channels.c PRE-CREATION 
  /trunk/main/pbx.c 384513 
  /trunk/main/manager_channels.c 384513 
  /trunk/main/features.c 384513 
  /trunk/main/dial.c 384513 
  /trunk/main/channel_internal_api.c 384513 
  /trunk/main/channel.c 384513 
  /trunk/include/asterisk/stasis_channels.h PRE-CREATION 
  /trunk/include/asterisk/channel.h 384513 
  /trunk/apps/app_userevent.c 384513 
  /trunk/apps/app_dial.c 384513 

Diff: https://reviewboard.asterisk.org/r/2383/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130402/2622ab51/attachment.htm>