[asterisk-dev] [Code Review] 2414: install_prereq: Build jansson from source, when necessary

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2414/
-----------------------------------------------------------

(Updated April 1, 2013, 3:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, Jason Parker and Matt Jordan.


Repository: Asterisk


Description
-------

When r383579 was committed, it made Jansson a required dependency.

While libjansson-dev and jansson-devel are available on recent
distros, some older (but still supported) distros don't have
it. There's a pull request[1] to get it into repoforge, but that still
doesn't help everyone. (And helps no one until the pull request is
merged and packages are built).

This patch adds Jansson install from source to the install_unpackaged()
function. There are a few gotcha's, which makes this change not
completely trivial.

 * Since Jansson may be installed by a package, don't install from
   source if a package installation can be found
   * libresample may also be installed via package, so I added a
     similar check to that.
 * Since Jansson installs into /usr/local, this patch also adds
   /usr/local/lib to /etc/ld.so.conf.d so that the library can be
   found.
   * The alternative was to install into /usr, but then it gets
     complicated having to deal with EL's /usr/lib{32,64} shenanigans.

 [1]: https://github.com/repoforge/rpms/pull/250


Diffs
-----

  /trunk/contrib/scripts/install_prereq 383913 

Diff: https://reviewboard.asterisk.org/r/2414/diff/


Testing
-------

Ran script on CentOS 5 and 6; it seemed to do the right thing.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130401/79e2e7db/attachment.htm>