[asterisk-dev] [Code Review] 2389: Transition Device State usage to Stasis

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2389/#review8162
-----------------------------------------------------------


Cursory review.


trunk/include/asterisk/devicestate.h
<https://reviewboard.asterisk.org/r/2389/#comment15743>

    Device state is built using stasis, but isn't really a part of stasis itself. I think it should have an ast_ prefix instead of a stasis_ prefix.



trunk/main/ccss.c
<https://reviewboard.asterisk.org/r/2389/#comment15744>

    This could be a race condition, if the task processor processes and decrements the refcount to 0 before you can increment the refcount.


- David Lee


On March 29, 2013, 9:03 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2389/
> -----------------------------------------------------------
> 
> (Updated March 29, 2013, 9:03 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21101
>     https://issues.asterisk.org/jira/browse/ASTERISK-21101
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In the move from Asterisk's event system to Stasis, this makes distributed device state aggregation always-on, removes unnecessary task processors where possible, and collapses aggregate and non-aggregate states into a single cache for ease of retrieval. This also removes an intermediary step in device state aggregation.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 384324 
>   trunk/include/asterisk/devicestate.h 384324 
>   trunk/include/asterisk/xmpp.h 384324 
>   trunk/main/asterisk.c 384324 
>   trunk/main/ccss.c 384324 
>   trunk/main/devicestate.c 384324 
>   trunk/main/pbx.c 384324 
>   trunk/res/res_jabber.c 384324 
>   trunk/res/res_xmpp.c 384324 
>   trunk/tests/test_devicestate.c 384324 
> 
> Diff: https://reviewboard.asterisk.org/r/2389/diff/
> 
> 
> Testing
> -------
> 
> This change was run against the queue integration tests, the generic_ccss test, the device_state_notification test, and the non_digium_state_change test with no ill effects.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130401/eae0a11d/attachment.htm>