[asterisk-dev] [JIRA] Closed: (ASTERISK-17367) [patch] AGI streamfile turns off moh, doesn't turn it on

[Olle E. Johansson]

28 sep 2012 kl. 13:34 skrev Joshua Colp <jcolp at digium.com>:

> Olle E. Johansson wrote:
>> 27 sep 2012 kl. 19:43 skrev Joshua Colp (JIRA)<noreply at issues.asterisk.org>:
>> 
>>>     [ https://issues.asterisk.org/jira/browse/ASTERISK-17367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>> 
>>> Joshua Colp closed ASTERISK-17367.
>>> ----------------------------------
>>> 
>>>    Resolution: Won't Fix
>>> 
>>> After reading the existing code, the patch, and the discussions that occurred as a result of this I have determined that changing the behavior is not warranted. Stopping music on hold within streamfile is done as a precaution to ensure it can play the file. It is not designed or expected to restore the state of the world to what it was to this degree. This can be accomplished in the AGI by calling set music before playing the file.
>>> 
>>> If there are situations where this is not possible I am completely willing to discuss them and re-evaluate my decision.
>> 
>> 
>> Josh,
> 
> Hola,
> 
>> I don't agree - in many other parts of Asterisk - and in the AGI - we turn generators on after we're done with the requested operation. I think that should be the default. If not, you will have to add documentation that clearly CLEARLY states that the AGI streamfile command turns off music on hold and it will stay off.
> 
> I've looked over the tree and I just don't see this happening like you say it does. Can you provide some examples? The cases that I see where something like music on hold is stopped and started are situations where it is explicitly expected and defined to do so, for example the Queue application when playing an announcement.
Haven't got the source code now, but I do not expect musiconhold to stop until I say so in any channel.

> As for changing the default behavior it's been like this for many, many, many years. Changing something that appears to be so simple but really fundamentally changes the behavior I really am against. I can see people using this behavior without expecting it. Ultimately in my view it would have to be another knob you turn on which effectively does the same as calling set music from the AGI afterwards OR a trunk only change so we don't surprise everyone.
In the issue I also commented on this, wanting a setting, but changing default behaviour in new releases.

> As for documentation, okay! That's reasonable.
Go ahead!

/O
> 
> Cheers,
> 
> -- 
> Joshua Colp
> Digium, Inc. | Senior Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at:  www.digium.com  & www.asterisk.org
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>  http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120928/04d0f12a/attachment.htm>