[asterisk-dev] [Code Review]: Sets -rpath linker option when appropriate

[David Lee]

> On Sept. 26, 2012, 2:24 p.m., Tilghman Lesher wrote:
> > Just by way of a note, when we first added the osx minimum version flag, it was meant to raise the floor, because at the time, if not specified, the Apple compiler would assume compatibility with 10.0.  At this point, since 10.8 is out, we could potentially raise that floor further, to 10.5 or 10.6, depending upon what minimum version of the Apple linker supports the -rpath option.

When merging to trunk, I plan on raising it to 10.5 (Leopard). (See my comment on the mailing list[1]). That's enough to add rpath support. I'd rather not make that change in 11, since that's exactly the sort of change that looks like it should be fine, but will turn around and bite us in ways we don't expect.

Apple's doesn't officially acknowledge end-of-support for OS versions; you just have to watch their security updates. Their most recent update[2] was released for 10.6 (Snow Leopard) and later. But Leopard received an update[3] in May of this year, and browser stats[4] show that it still has 10% of the overall Mac market. That's enough for me to say that 10.5 is a high enough minimum (until we find some other compiler flag we want to turn on that requires a higher minimum version).

 [1]: http://lists.digium.com/pipermail/asterisk-dev/2012-September/057013.html
 [2]: http://support.apple.com/kb/HT1222
 [3]: http://support.apple.com/kb/HT5283
 [4]: http://www.netmarketshare.com/operating-system-market-share.aspx?qprid=10&qpcustomb=*2


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2132/#review7158
-----------------------------------------------------------


On Sept. 26, 2012, 1:28 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2132/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 1:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sets -rpath linker option when appropriate.
> 
>  * For OS's other than OS X, add the -rpath linker option if libdir is
>    anything other than /lib or /usr/lib. This can be disabled by
>    passing --disable-rpath to ./configure.
>  * For OS X, we have macosx_version_min set to 10.4, which doesn't
>    support rpath. So instead, the patch adds the -dynamiclib and
>    -install_name flags for linking libasteriskssl.dylib, along with
>    cleaning up some of the other OS X specific linker flags.
> 
> 
> This addresses bug ASTERSIK-20407.
>     https://issues.asterisk.org/jira/browse/ASTERSIK-20407
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 373734 
>   /branches/11/configure UNKNOWN 
>   /branches/11/configure.ac 373734 
>   /branches/11/main/Makefile 373734 
>   /branches/11/makeopts.in 373734 
> 
> Diff: https://reviewboard.asterisk.org/r/2132/diff
> 
> 
> Testing
> -------
> 
> Built on OS X and Ubuntu Precise, --prefix=/opt/Asterisk, both with and without --disable-rpath.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120926/d3c62ccf/attachment-0001.htm>