[asterisk-dev] [Code Review] app_queue: initialise "available agent' hint on restart, and other senarios

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2129/#review7156
-----------------------------------------------------------

Ship it!


Looks good!


trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/2129/#comment13810>

    Red blob


- Matt


On Sept. 25, 2012, 5:45 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2129/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 5:45 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> On queue initialisation set queue_avail devstate to INUSE.
>  Previously was unavailable, which indicated an agent was available.
> 
> When removing members, if there are no other members available, set queue_avail to INUSE.
>  Previously, if a member interface had become 'unavailable', they were never going to be removed, particularly when persistant queues is enabled.
> 
> When adding a member, check that they are available, if they are set queue_avail to NOT_INUSE.
>  Previously on reloaded, members may have been 'unavailable'.
> 
> When pausing or unpausing a member, set appropriate queue availability. 
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 373274 
> 
> Diff: https://reviewboard.asterisk.org/r/2129/diff
> 
> 
> Testing
> -------
> 
> Using CLI added non connected user to queues. Queue_avail state stayed at INUSE as expected.
>  
> Using CLI added and removed connected users to queues. Queue_avail state changed to NOT_INUSE then INUSE as expected.
> 
> Removed power from the only queue member and waited for the state to go unavailable, the queue_avail then went INUSE.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120926/45e80948/attachment.htm>