[asterisk-dev] [Code Review] Support a hint on a queue.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1619/
-----------------------------------------------------------

(Updated Sept. 18, 2012, 5:08 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated to remove debug statements.
Only call ast_devstate_changed() when the first member enters the queue, same style as app_meetme.


Summary
-------

Note: the 2 debug print lines will go.

Picking up queues is possible, but knowing that a queue is ringing is useful,
particulary when you are not logged in to that queue, or not a member of it.

Non BLF users, dial 72# and then are connected with caller.
If they forget to press # or the SEND button they think the pickup hasn't worked.
Not understanding there is a 3-4 second delay before the SIP call is placed.

Example 1: Night Queue with a permanent member (specifcially just bells):

exten => 72,hint,Queue:night_queue ;queue NIGHT BELL

exten => _72,1,NoOp(Pickup Night Bell)
exten => _72,n,Pickup(4999 at isdn)    ;direct call pickup to local Asterisk
exten => _72,n,NoOp(PICKUPRESULT=${PICKUPRESULT})
exten => _72,n,Hangup()

exten => **72,1,Goto(72,1)


Example 2: Queue with Dynamic Users:
Note: we use '_' in the queue names, and '-' for the context 

[trusted]
exten => 8501,hint,Queue:itg_queue        ;Provide a hint for the queue
exten => _**8501,1,Pickup(itg at trusted)    ;Pickup the queue

exten => 8501,1,Goto(itg-queue,itg,1)     ;Ring the queue

[itg-queue]
exten => itg,1,Queue(itg_queue,crhH,,,127)


Diffs (updated)
-----

  trunk/apps/app_queue.c 373162 

Diff: https://reviewboard.asterisk.org/r/1619/diff


Testing
-------

In use for months on a 1.8.5 production box.

NightBell usage:

Users with BLFs configured hear the nightbells, and see the BLF flash, press the BLF and are immediately connected with caller.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120918/e2e50a2b/attachment-0001.htm>