[asterisk-dev] [Code Review]: chan_sip: Manager action SIPQualifyPeer response changes

[jrose]

> On Sept. 7, 2012, 7:06 a.m., Olle E Johansson wrote:
> > /trunk/channels/chan_sip.c, line 18954
> > <https://reviewboard.asterisk.org/r/2098/diff/1/?file=31146#file31146line18954>
> >
> >     Maybe SIpQualifyPeerResult?
> >     
> >     Complete is usually at the end of a listing.

Hey Olle, I've been pondering this, and while I agree that Complete seems mildly inappropriate since that is usually involved with a list, I also disagree with Result since this isn't actually telling anything about the results of the sip_poke_peer (and as far as I know, there is no need for it to).

If you could help me pick from among these, I'd appreciate it.

* SIPQualifyPeerCompleted (it's got a d on the end which kinda differentiates it from complete)
* SIPQualifyPeerFinished
* SIPQualifyPeerDone


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2098/#review7023
-----------------------------------------------------------


On Sept. 6, 2012, 11:47 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2098/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2012, 11:47 a.m.)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Last week a patch was made to add some feedback for SIPQualifyPeer upon completion. Olle brought up the point that sip_poke_peer may take a considerable amount of time to resolve, so this patch adds an acknowledgement of 'will qualify' right before performing the sip_poke_peer. The response upon completion of the poke has been removed and instead an event is in place (SIPQualifyPeerComplete) to address that.
> 
> Matt mentioned in the same email thread that the event itself may not be necessary. Further discussion didn't take place, so that needs to be answered. If we decide the event is appropriate, it will need to be documented.
> 
> 
> This addresses bug AST-969.
>     https://issues.asterisk.org/jira/browse/AST-969
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 371997 
> 
> Diff: https://reviewboard.asterisk.org/r/2098/diff
> 
> 
> Testing
> -------
> 
> The simple stuff, ran qualify peer event and made sure the response and event went through as expected.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120907/e4e41b4d/attachment.htm>