[asterisk-dev] [Code Review] app_alarmreceiver cleanup and fixes

[Pedro Kiefer]

Was this patch merged already? What is blocking it?

On Aug 30, 2012, at 11:50 AM, Mark Michelson wrote:

> This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2075/
> 
> Ship it!
> 
> Looks good by me. Thanks for making the requested changes.
> 
> - Mark
> 
> 
> On August 28th, 2012, 9:27 a.m., KNK wrote:
> 
> Review request for Asterisk Developers.
> By KNK.
> Updated Aug. 28, 2012, 9:27 a.m.
> 
> Description
> 
> Review on behalf of Pedro Kiefer: cleanups from ASTERISK-20224, ASTERISK-20157 and the updated ASTERISK-16694 (author Fred van Lieshout) + improvement from ASTERISK-20158
> There are several issues opened for bugs in app_alarmreceiver (ASTERISK-19435, ASTERISK-18417, ASTERISK-16694 and ASTERISK-16668), which go away after the cleanup (ASTERISK-16694) replacing the proprietary toneburst code with ast_playtones_ functions, so the fix from ASTERISK-19435 is no longer necessary.
> The new functionality from ASTERISK-20158 is a bugfix on my opinion, because 'we get stuck on the alarm receiver app until it times out'
> Testing
> 
> Compile test only
> Bugs: ASTERISK-16668, ASTERISK-16694, ASTERISK-18417, ASTERISK-19435, ASTERISK-20157, ASTERISK-20158, ASTERISK-20224
> Diffs
> 
> /trunk/apps/app_alarmreceiver.c (370760)
> View Diff
> 
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120904/0e408722/attachment.htm>