[asterisk-dev] [Code Review]: Wiki page for direct media glare avoidance in Asterisk 11

Mark Michelson reviewboard at asterisk.org
Tue Sep 4 09:46:29 CDT 2012



> On Sept. 4, 2012, 9:35 a.m., jrose wrote:
> > "This is where the directmedia = outgoing setting becomes useful."
> > 
> > My only very minor complaint is that this is phrased a little weirdly/informally. Perhaps consider:
> > 
> > "The 'outgoing' setting for the directmedia option addresses this problem.

Fixed. I also fixed some other odd wordings and grammatical problems I spotted after giving the page a re-read.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2091/#review7002
-----------------------------------------------------------


On Aug. 29, 2012, 4:06 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2091/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2012, 4:06 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Take a look at https://wiki.asterisk.org/wiki/display/AST/SIP+Direct+Media+Reinvite+Glare+Avoidance
> 
> Let me know if things are unclear or if there is anything I should add or remove.
> 
> 
> This addresses bug ASTERISK-20273.
>     None
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/2091/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120904/f6acbf15/attachment.htm>


More information about the asterisk-dev mailing list