[asterisk-dev] [Code Review]: logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

[jrose]

> On May 31, 2012, 3:07 p.m., opticron wrote:
> > /trunk/channels/chan_dahdi.c, line 13819
> > <https://reviewboard.asterisk.org/r/1927/diff/2/?file=28263#file28263line13819>
> >
> >     I don't quite understand this message.  Was it just for debugging purposes?

Probably.  I'm getting rid of it, I'm pretty sure it isn't something I mean to leave in.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6366
-----------------------------------------------------------


On May 24, 2012, 4:32 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 4:32 p.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 367420 
>   /trunk/channels/chan_dahdi.c 367420 
>   /trunk/channels/chan_iax2.c 367420 
>   /trunk/channels/chan_local.c 367420 
>   /trunk/channels/sig_analog.c 367420 
>   /trunk/channels/sig_pri.c 367420 
>   /trunk/main/autoservice.c 367420 
>   /trunk/main/logger.c 367420 
>   /trunk/main/pbx.c 367420 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/e0425a48/attachment-0001.htm>