[asterisk-dev] [Code Review]: Add unique message IDs to IMAP voicemail

[Mark Michelson]

> On May 31, 2012, 8:47 a.m., opticron wrote:
> > /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c, lines 2516-2517
> > <https://reviewboard.asterisk.org/r/1945/diff/1/?file=28244#file28244line2516>
> >
> >     The channel opaquification changes here seem out of place.  Was this just forgotten and not actually compiling before?

I thought that's what the problem was, but the circumstance is a bit more bizarre. In trunk, the opaquification changes were made properly, but my branch, based on trunk and automerging from trunk, did not have the opaquification changes in the IMAP code. I don't know how that happened, but I imagine it was based on something I did where I ported some code into my branch from some place other than trunk.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1945/#review6354
-----------------------------------------------------------


On May 23, 2012, 3:46 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1945/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review has two main parts to it.
> 
> 1) IMAP voicemail storage now supports unique message IDs like the other storage backends.
> 2) Old IMAP voicemails that do not have a unique message ID can be updated to have one now. This involves deleting the old message, creating a new one, and then storing that message in the appropriate folder. Comments in the code explain what is going on.
> 
> 
> Diffs
> -----
> 
>   /team/mmichelson/trunk-digiumphones/apps/app_voicemail.c 367360 
> 
> Diff: https://reviewboard.asterisk.org/r/1945/diff
> 
> 
> Testing
> -------
> 
> Admittedly, this has only undergone a compilation test.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/59f9b036/attachment.htm>