[asterisk-dev] [Code Review] Add test for correct HANGUPCAUSE after SIP 404

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1951/#review6355
-----------------------------------------------------------



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11869>

    This line shouldn't be necessary since you're creating the AMI factory in run() below.



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11873>

    You should be able to leave the error callback out entirely if you don't want to handle that case.



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11872>

    This isn't necessary since you haven't registered this function for any callbacks other than Hangup.



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11871>

    Just a nitpick, there is no need to complicate this with a list if you aren't going to use the information later.  A simple count will suffice.



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11866>

    This line is no longer required.



/asterisk/trunk/tests/channels/SIP/sip2cause/run-test
<https://reviewboard.asterisk.org/r/1951/#comment11867>

    Ditto.


- opticron


On May 29, 2012, 3:57 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1951/
> -----------------------------------------------------------
> 
> (Updated May 29, 2012, 3:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> See ASTERISK-19914 and preceding discussion in http://lists.digium.com/pipermail/asterisk-dev/2012-May/055309.html
> 
> Apparently r351130 broke correct HANGUPCAUSE setting in certain cases. This only tests the 404 case. Feel free to expand it later if needed.
> 
> 
> P.S. There are now 3 test cases that concern hangupcauses. That might cause confusion:
>   hangupcause => tests ${HASH*(HANGUPCAUSE,*)}
>   sip_cause => tests ${HASH*(SIP_CAUSE,*)}
>   sip2cause => tests _getting_ ${HANGUPCAUSE} (and implicit propagation)
> 
> 
> This addresses bug ASTERISK-19914.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19914
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/sipp/invite_recv_do_404.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/sip2cause/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3241 
> 
> Diff: https://reviewboard.asterisk.org/r/1951/diff
> 
> 
> Testing
> -------
> 
> Before chan_sip.diff from ASTERISK-19914 on 1.8.x.
> 
> <?xml version="1.0" encoding="utf-8"?>
> <testsuite errors="0" failures="1" name="AsteriskTestSuite" tests="1" time="7.43">
>   <testcase name="tests/channels/SIP/sip2cause" time="7.43">
>     <failure>
>       Running ['tests/channels/SIP/sip2cause/run-test'] ...
> [May 29 08:31:35] ERROR[14215]: __main__:69 on_hangup: Unexpected HANGUPCAUSE 34 (not 1) for channel SIP/alice-00000000
> [May 29 08:31:40] ERROR[14215]: __main__:69 on_hangup: Unexpected HANGUPCAUSE 0 (not 1) for channel Local/1111 at dial-alice-1c03;1
> [May 29 08:31:40] ERROR[14215]: __main__:69 on_hangup: Unexpected HANGUPCAUSE 34 (not 1) for channel Local/1111 at dial-alice-1c03;2
> 
>     </failure>
>   </testcase>
> </testsuite>
> 
> 
> After chan_sip.diff on 1.8.x (and on 1.6.2.x):
> 
> <?xml version="1.0" encoding="utf-8"?>
> <testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" time="12.54">
>   <testcase name="tests/channels/SIP/sip2cause" time="12.54"/>
> </testsuite>
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120531/33a0f06b/attachment.htm>