[asterisk-dev] [Code Review]: Patch to detect/parse ANI-II / ANI2 / OLI from SIP INVITE messages

[Rob Gagnon]

> On May 24, 2012, 2:52 p.m., Mark Michelson wrote:
> > I've given a ship it! on this because nothing on this review is actually "wrong". These are merely suggestions.
> 
> Rob Gagnon wrote:
>     Can someone remove the ship-it for now....  I would rather run more tests since I recently had to change the patch due to a somewhat rare (about 1 in 500 or so calls) seg fault that occurs during the initialization of the chan->caller.ani2 = 0; line of code.

New patch has been uploaded to resolve the hold on the "ship-it" noted above.  Code has been live for about 10 hours processing about 550,000 calls since it was fixed, without any segmentation faults due to null pointer problems.


- Rob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1947/#review6317
-----------------------------------------------------------


On May 30, 2012, 12:04 p.m., Rob Gagnon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1947/
> -----------------------------------------------------------
> 
> (Updated May 30, 2012, 12:04 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, and Rob Gagnon.
> 
> 
> Summary
> -------
> 
> Add ANI2 / OLI parsing for SIP.  The patch checks the "From" header during the handle_request_invite() function for the presence of "isup-oli", "ss7-oli", or "oli" tags.  If present, the up-to-2-digits following the equal sign in the tag are set on the channel's caller structure in the "ani2" int element.
> 
> This allows SIP functions that reference ANI2 to work properly for SIP.  Specifically tested was the messaging that occurs when AGI transmits its data to an AGI script.
> 
> 
> This addresses bug ASTERISK-19912.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19912
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 367975 
> 
> Diff: https://reviewboard.asterisk.org/r/1947/diff
> 
> 
> Testing
> -------
> 
> Call processing via AGI call in dial plan which logs all AGI incoming values was executed from cell phone, land line, and payphone.  During the payphone call, the value of "agi_callingani2" was properly transmitted as "7" while the others were "0"
> 
> 
> Thanks,
> 
> Rob
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120530/6f0983f5/attachment.htm>