[asterisk-dev] [Code Review]: logger: Callid logging phase IV - chan_local, chan_agent, bridging and autoservice.

[jrose]

> On May 29, 2012, 5:59 p.m., Mark Michelson wrote:
> > /trunk/main/bridging.c, lines 1175-1177
> > <https://reviewboard.asterisk.org/r/1950/diff/1/?file=28281#file28281line1175>
> >
> >     This if is unnecessary. The bridge channel was just allocated, so it definitely has no callid yet.
> >

Dropped the conditions, kept the setting of callid to threadstorage callid.

Iax2 and chan_dahdi aren't actually part of this review, so if that's all there is for it, awesome.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1950/#review6339
-----------------------------------------------------------


On May 25, 2012, 2:06 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1950/
> -----------------------------------------------------------
> 
> (Updated May 25, 2012, 2:06 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This should be the last set of programming changes.  This review's diff file includes uncommitted changes to dahdi+iax and some other stuff that may be covered by the phase 3 review, but focus should stay on the four things mentioned.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 367420 
>   /trunk/channels/chan_dahdi.c 367420 
>   /trunk/channels/chan_iax2.c 367420 
>   /trunk/channels/chan_local.c 367420 
>   /trunk/channels/sig_analog.c 367420 
>   /trunk/channels/sig_pri.c 367420 
>   /trunk/main/autoservice.c 367420 
>   /trunk/main/bridging.c 367420 
>   /trunk/main/logger.c 367420 
>   /trunk/main/pbx.c 367420 
> 
> Diff: https://reviewboard.asterisk.org/r/1950/diff
> 
> 
> Testing
> -------
> 
> Each channel driver was tested to make sure log messages made within related threads would bind properly and the specific channel drivers would also get the right callids referenced.  Bridging api was tested via the confbridge application, and in each case the bridge threads bind to the callid of the channel that started the bridge.  Autoservice was tested via the system dialplan application and threads created by it were similarly bound based on the callid of the channel that started the autoservice.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120530/c21be8b0/attachment.htm>