[asterisk-dev] RFC: chan_sip SDP parsing changes in behavior

[Paul Belanger]

On 12-05-30 09:26 AM, Matthew Jordan wrote:
>
> ----- Original Message -----
>> From: "Paul Belanger"<paul.belanger at polybeacon.com>
>> To: asterisk-dev at lists.digium.com
>> Sent: Wednesday, May 30, 2012 8:18:59 AM
>> Subject: Re: [asterisk-dev] RFC: chan_sip SDP parsing changes in behavior
>>
>
> <snip>
>
>> Also, have we added any new tests for this patch?  Testing
>> functionality
>> before and after the change?  All I can see if 'Compile testing
>> only',
>> which I'm not a fan off when we are talking about 'changes in
>> behavior'.
>>    I would be more comfortable with 1.8 and 10 if we did have the
>>    tests.
>>
>
> The TestSuite contains the SDP_offer_answer test, which covers a variety
> of media negotiation scenarios.  While it certainly doesn't cover everything
> (such as some of the scenarios Kevin's patch addresses), it would provide
> a base level of assurance that common media negotiation scenarios aren't
> broken by a patch.
>
Cool, so that is a start to make sure we don't break anything.  Have we 
at least done a smoke test with the major SIP phones?  EG: polycom, 
cisco, etc?

-- 
Paul Belanger | PolyBeacon, Inc.
Jabber: paul.belanger at polybeacon.com | IRC: pabelanger (Freenode)
Github: https://github.com/pabelanger | Twitter: 
https://twitter.com/pabelanger