[asterisk-dev] [Code Review]: Remove AST_FLAG_ANSWERED_ELSEWHERE, duplicating the functionality of AST_CAUSE_ANSWERED_ELSEWHERE

[Birger Harzenetter]

> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/apps/app_dial.c, line 136
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28236#file28236line136>
> >
> >     This description needs to be changed.

changed


> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/apps/app_queue.c, line 4761
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28237#file28237line4761>
> >
> >     Reference to flag, also red blob.

changed


> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/channels/chan_local.c, line 913
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28238#file28238line913>
> >
> >     This reference to flag should be changed.

changed


> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/channels/chan_local.c, line 1034
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28238#file28238line1034>
> >
> >     This reference to flag should be changed.

changed


> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/include/asterisk/channel.h, lines 838-841
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28241#file28241line838>
> >
> >     This should probably just be removed entirely.

As I have no idea if any 3rd party modules might make use of the flag, I thought it might be a good idea to leave this reference so developers or users can easily see what happened.


> On May 25, 2012, 7:57 a.m., opticron wrote:
> > trunk/main/features.c, line 7654
> > <https://reviewboard.asterisk.org/r/1944/diff/1/?file=28243#file28243line7654>
> >
> >     This reference to flag should be changed.

Replaced by a more generic comment as that looks rather SIP specific.


- Birger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1944/#review6322
-----------------------------------------------------------


On May 23, 2012, 8:44 a.m., Birger Harzenetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1944/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 8:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While 'real' channels use AST_CAUSE_ANSWERED_ELSEWHERE, local channels and queues use AST_FLAG_ANSWERED_ELSEWHERE for the same purpose.
> This patch replaces all occurrences of the flag by the cause code, removing the duplicated functionality and the flag itself.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_dial.c 367263 
>   trunk/apps/app_queue.c 367263 
>   trunk/channels/chan_local.c 367263 
>   trunk/channels/chan_sip.c 367263 
>   trunk/channels/chan_unistim.c 367263 
>   trunk/include/asterisk/channel.h 367263 
>   trunk/main/channel_internal_api.c 367263 
>   trunk/main/features.c 367263 
> 
> Diff: https://reviewboard.asterisk.org/r/1944/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Birger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120526/22c3e096/attachment.htm>