[asterisk-dev] [Code Review]: logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

[jrose]

> On May 24, 2012, 4:36 p.m., jrose wrote:
> > /trunk/channels/sig_pri.c, lines 6157-6166
> > <https://reviewboard.asterisk.org/r/1927/diff/2/?file=28267#file28267line6157>
> >
> >     All of this changing c to chan stuff can go since I ended up not doing anything here.

By the way, I still feel on this review that the focus should remain on chan_dahdi and iax2.  Autoservice changes, chan_agent and chan_local will be split into a separate review.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6325
-----------------------------------------------------------


On May 24, 2012, 4:32 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 4:32 p.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 367420 
>   /trunk/channels/chan_dahdi.c 367420 
>   /trunk/channels/chan_iax2.c 367420 
>   /trunk/channels/chan_local.c 367420 
>   /trunk/channels/sig_analog.c 367420 
>   /trunk/channels/sig_pri.c 367420 
>   /trunk/main/autoservice.c 367420 
>   /trunk/main/logger.c 367420 
>   /trunk/main/pbx.c 367420 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120525/960189cc/attachment.htm>