[asterisk-dev] [Code Review] Start a library of common SIPp scenarios for the testsuite

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1929/#review6290
-----------------------------------------------------------

Ship it!


This looks pretty good to me.  You may want to include verification of NOTIFY body content on transfer in one of the examples just to show how it's done.


/asterisk/trunk/contrib/sipp/calls/uac-blind-transfer.xml
<https://reviewboard.asterisk.org/r/1929/#comment11736>

    Blob.



/asterisk/trunk/contrib/sipp/calls/uac-blind-transfer.xml
<https://reviewboard.asterisk.org/r/1929/#comment11737>

    Blob.



/asterisk/trunk/contrib/sipp/calls/uas-blind-transfer.xml
<https://reviewboard.asterisk.org/r/1929/#comment11738>

    Blob.



/asterisk/trunk/contrib/sipp/calls/uas-blind-transfer.xml
<https://reviewboard.asterisk.org/r/1929/#comment11739>

    Blob.


- opticron


On May 18, 2012, 3:28 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1929/
> -----------------------------------------------------------
> 
> (Updated May 18, 2012, 3:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When writing tests, I find that SIPp scenarios are a common need. My typical method of starting a new scenario is to either
> 
> 1. Dump the default "uac" or "uas" scenario using sipp -sd and then tweak it to suit my needs or
> 2. Try to find an existing test that likely has a scenario like what I would need and tweak that to suit my needs.
> 
> This aims to begin a library of commonly-needed SIPp scenarios, so that writing tests can be quicker and easier. I have also included a table_of_contents text file that has brief explanations for the scenarios and how they are used. The table_of_contents can be added to when new scenarios are added to the library. There is probably a better method of cataloging the tests than a text file, but I just wanted to get something together to show off for the review.
> 
> Let me know what you think. I know there are a bunch of scenario types that are not currently represented (such as anything requiring authentication or tests that use direct media). What I'm more interested in at the moment is if the concept is good and if this would be welcome to the testsuite.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/contrib/sipp/calls/uac-blind-transfer.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uac-hangup.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uac-no-hangup.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uas-blind-transfer.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uas-hangup.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uas-no-hangup.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/calls/uas-redirect.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/registration/uac-register.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/registration/uac-unregister.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/subscription/uac-subscribe-no-unsubscribe.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/subscription/uac-subscribe-unsubscribe.xml PRE-CREATION 
>   /asterisk/trunk/contrib/sipp/table_of_contents PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1929/diff
> 
> 
> Testing
> -------
> 
> The scenarios included in this review are either already in use in the test suite or are modified versions (to be more generic) of scenarios already in the testsuite. Therefore, the scenarios have no issues as written.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120522/6f433ebd/attachment-0001.htm>