[asterisk-dev] [Code Review]: Add CEL testing to the testsuite

[Terry Wilson]

> On May 17, 2012, 8:41 a.m., Matt Jordan wrote:
> > /asterisk/trunk/runtests.py, line 431
> > <https://reviewboard.asterisk.org/r/1901/diff/2/?file=27743#file27743line431>
> >
> >     What uses this return value?

Ah, I forgot I did that.

The reason I did this was that whether there are test failures or not, runtests.py always exited 0. This made it impossible to run the script in a loop until a test failed.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1901/#review6232
-----------------------------------------------------------


On May 7, 2012, 4:43 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1901/
> -----------------------------------------------------------
> 
> (Updated May 7, 2012, 4:43 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> This moves the CSV processing out of cdr.py into astcsv.py. CDR and CEL inherit from there. CDRTestCase is modified to allow passing expectations for CEL as well. When using CDRTestCase, one has to put in entries for *all* expected CDR or CEL entries. For CEL, that is a *lot* of entries. Instead of using CDRTestcCase to just test CDR/CELs (and only test them with Local channels), just adding a few lines of code to other existing tests might really be the best use of the CDR/CEL modules since we want to make sure CDR/CELs are correct for a wide array of situations.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/configs/cel.conf PRE-CREATION 
>   /asterisk/trunk/configs/cel_custom.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/astcsv.py PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/cdr.py 3204 
>   /asterisk/trunk/lib/python/asterisk/cel.py PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/self_test/CELMaster1.csv PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/self_test/CELMaster2.csv PRE-CREATION 
>   /asterisk/trunk/runtests.py 3204 
>   /asterisk/trunk/tests/iax2/basic-call/run-test 3204 
> 
> Diff: https://reviewboard.asterisk.org/r/1901/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120521/7ff57773/attachment-0001.htm>