[asterisk-dev] [Code Review] chan_sip: Fix directmedia's use of ACL to limit remotebridging to certain host addresses for trunk

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1924/
-----------------------------------------------------------

(Updated May 21, 2012, 9:29 a.m.)


Review request for Asterisk Developers, Mark Michelson and Matt Jordan.


Changes
-------

Addressing above review.


Summary
-------

Related to https://reviewboard.asterisk.org/r/1899/ which has some locking changes that need to be made still...

This patch takes Mark's suggested approach for adding callbacks for the rtp_bridge function to be able to supply two channels for determining rtp glue stuff in cases where a channel driver needs data about both peers in order to determine what types of bridging are permissible.


This addresses bug AST-876.
    https://issues.asterisk.org/jira/browse/AST-876


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 366775 
  /trunk/include/asterisk/rtp_engine.h 366775 
  /trunk/main/rtp_engine.c 366775 

Diff: https://reviewboard.asterisk.org/r/1924/diff


Testing
-------

Similar to the testing done for the review 1899 version.  Calls were tested with and without directmediapermit/deny on both sides of a call with calls being started from both directions. Specific things tested include whether or not the host address lists were copied properly (because that was a rather substantial problem earlier on) and the results of ast_apply_ha in each case.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120521/65f6133d/attachment.htm>